Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what to do about IDNA encoding #125

Open
mithrandi opened this issue Jan 10, 2018 · 1 comment
Open

Decide what to do about IDNA encoding #125

mithrandi opened this issue Jan 10, 2018 · 1 comment
Labels
bug
Milestone
1.0.0 release

Comments

@mithrandi
Copy link
Contributor

Cryptography no longer IDNA encodes names for us, should we be doing this instead?
@mithrandi mithrandi added the bug label Jan 10, 2018
@mithrandi mithrandi added this to the 1.0.0 release milestone Jan 10, 2018
@markrwilliams
Copy link
Member

markrwilliams commented Jan 10, 2018 •
edited
Loading

Cryptography no longer IDNA encodes names for us, should we be doing this instead?

Yes - perhaps this can begin by making ICertificateStore impose an encoding for server_name? This should be pretty easy for DirectoryStore because it's already got to deal with whatever sys.getfilesystemencoding claims the PEM path's encoding should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.0 release
Development

No branches or pull requests
2 participants
@markrwilliams @mithrandi