Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable voice's waveforms when it's silent #18

Open
Windfisch opened this issue Feb 19, 2023 · 1 comment
Open

Disable voice's waveforms when it's silent #18

Windfisch opened this issue Feb 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Windfisch
Copy link
Collaborator

After a voice has finished releasing, turn off its waveforms to avoid it bleeding through due to the leaky VCA

@Windfisch Windfisch added the enhancement New feature or request label Feb 19, 2023
@Sequence7
Copy link

Sequence7 commented Mar 30, 2023

I seen you mention this in the code, but also setting the frequency to 0 should stop the sids bleeding their last played frequency as background noise. Also probably tricky to implement (would have to know exactly when notes are playing) the waveforms and gate are atleast in the same register of the sid (thats how it is done in assembly atleast) but the frequency would be a different call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants