Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdStackServer connections ConcurrentHashmap holding on to connections and running out of memory #872

Open
vikramkadi opened this issue Sep 8, 2020 · 1 comment

Comments

@vikramkadi
Copy link

Finagle http server(version: 6.39.0) seems to not release older connections from the concurrenthashmap/set increasing old gen space overtime.

Expected behavior

The connections bookkeeping set/map should clean up older entries(https://github.com/twitter/finagle/blob/finagle-6.39.0/finagle-core/src/main/scala/com/twitter/finagle/server/StackServer.scala#L230).

Actual behavior

On taking a jvm heap dump at multiple times during the day for a high qps finagle server, we see that the connections set/map is not flushing out some of the older connections that just stay and keep taking up large amounts of memory

Steps to reproduce the behavior

  • A high qps server with some huge responses(think 50mb)
@enbnt
Copy link
Contributor

enbnt commented Sep 8, 2020

Hi @vikramkadi, have you tried reproducing this issue with a more recent version of Finagle? The 6.39 version appears to be from 2016 and the code has changed significantly. I would recommend trying an upgrade and seeing if the issue persists. If it is still there on the latest release, we will need to gather some more context to assist. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants