Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FuzzyEquals not working for hebrew charachters #5

Open
yosimaurer opened this issue Apr 25, 2018 · 2 comments
Open

FuzzyEquals not working for hebrew charachters #5

yosimaurer opened this issue Apr 25, 2018 · 2 comments

Comments

@yosimaurer
Copy link

FuzzyEquals and FuzzyMatches does not work with hebrew charachters - and seem to ignore them.

However other fuzzy methods like DiceCoefficient work well.

sample code:

string str1 = "אבג";
string str2 = str1;

        Console.WriteLine(str1.FuzzyEquals(str2));
        Console.WriteLine(str1.FuzzyMatch(str2));

        str1 = "abc";
        str2 = str1;
        Console.WriteLine(str1.FuzzyEquals(str2));
        Console.WriteLine(str1.FuzzyMatch(str2));

Results:

False
-0.0625
True
0.999999

@tylerje
Copy link
Member

tylerje commented Jul 10, 2020

FuzzyMatches is based on Latin character set. See https://github.com/tylerjensen/FuzzyStrings/blob/master/src/DuoVia.FuzzyStrings/DuoVia.FuzzyStrings/StringExtensions.cs#L53

I'm open to a pull request to resolve that for other character sets.

@tylerje
Copy link
Member

tylerje commented Jul 10, 2020

@yosimaurer the primary problem would be the DoubleMetaphone algorithm that relies on Latin character set and generic English pronunciation. To support another language/character set, you would need to extend that algorithm and modify the FuzzyMatches mashup algo that uses all four of the base algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants