Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss: Merge Glimmer Syntax VSCode extension into Glint 2 #763

Open
machty opened this issue Sep 23, 2024 · 0 comments
Open

Discuss: Merge Glimmer Syntax VSCode extension into Glint 2 #763

machty opened this issue Sep 23, 2024 · 0 comments

Comments

@machty
Copy link
Contributor

machty commented Sep 23, 2024

When I first started a Volar spike of Glint, I had to copy the glimmer syntax definitions from vsc-ember-syntax in order for Volar to work. I think the specific reason is that vsc-ember-syntax defines the glimmer-ts and glimmer-js language IDs that Volar expects to be present in order to generate VirtualCodes that use/specify those language ideas.

In other words, Volar needs the syntax definitions to be present in the same project/VSCode extension as the Volar-ized LS/TS-Plugin extension.

So, I've actually already merged in the glimmer-ts syntax, but it's a bit of a hack job, so we should use this issue to discuss:

  1. Is it OK that I merged the syntax in?
  2. Is there a strong compelling reason to keep the syntax extension separate? (and it should be a strong enough reason to push against Volar conventions)
  3. Are there tests or niceties from the vsc-ember-syntax extension I should bring over?
  4. Do I need to update any files to add authorship / attribution in Glint?
@machty machty changed the title Plan for how to merge Glimmer Syntax VSCode extension into Glint 2 (or post-merged ELS) Merge Glimmer Syntax VSCode extension into Glint 2 (or post-merged ELS) Sep 23, 2024
@machty machty changed the title Merge Glimmer Syntax VSCode extension into Glint 2 (or post-merged ELS) Discuss: Merge Glimmer Syntax VSCode extension into Glint 2 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant