-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can this depends on @types? #1
Comments
@unional are you saying I should have these as dependencies in the I had based this on |
Yes, and keeping the But the dependencies still need to be clarified. |
I have turned on Travis already. When there is a new commit, then the travis should start working. |
@unional I just tried to add these as npm dependencies. There are a couple issues:
|
sorry, I meant using the |
@unional ah, gotcha. Those two should be fine, but relying on |
It's perfectly correct 👍 The thing we're considering is that, with NPM |
@blakeembrey yea I get what we're trying to do; and that should be fine for Is there a solution to this? Could we just use a GitHub dependency for |
Absolutely, this is the end goal - allowing people to use from GitHub until microsoft/types-publisher#4 is done. All that's needed to support this should be in https://github.com/types/_guidelines (just add version and name to |
@Blakeembery sorry, too busy at work. Didn't get a chance to get to this. |
.... Embrey! XD |
@unional @blakeembrey I have a PR up for this (#2), could one of you have a look? I'm getting a failure on TS v1.8, |
For the two deps:
bluebird
andrethinkdb
, andnode
. in package.json@blakeembrey @marshall007
The text was updated successfully, but these errors were encountered: