Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove Dependence on Swiftz #21

Closed
wants to merge 9 commits into from
Closed

[WIP] Remove Dependence on Swiftz #21

wants to merge 9 commits into from

Conversation

CodaFi
Copy link
Member

@CodaFi CodaFi commented Oct 15, 2015

Kinda sorta fixes #8 and assuages our fears about some duplications.

@CodaFi CodaFi changed the title Remove Dependence on Swiftz [WIP] Remove Dependence on Swiftz Oct 15, 2015
@CodaFi
Copy link
Member Author

CodaFi commented Oct 15, 2015

OK, the last thing left is Either. It wouldn't be hard to ship our own and completely break dependence on Swiftz - call it Vee or Disjunct or Sum or even Or.

@CodaFi
Copy link
Member Author

CodaFi commented Oct 15, 2015

We also lose a couple of Monoid things in Basic, but those can mostly be recovered through IntegerType constraints

@pthariensflame
Copy link
Member

Sorry for being unreachable for a while! My long-planned upgrade to Focus also needs an Either, but doesn't really depend on Swiftx for anything else. Should we maybe consider making a microframework just containing a minimal Either type?

pthariensflame
pthariensflame reviewed Oct 19, 2015
View reviewed changes
.gitmodules
@@ -7,3 +7,6 @@
[submodule "Carthage/Checkouts/Swiftz"]
path = Carthage/Checkouts/Swiftz
url = https://github.com/typelift/Swiftz.git
[submodule "Carthage/Checkouts/Operadics"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to remove Swiftz's submodule.

@CodaFi
Copy link
Member Author

CodaFi commented Oct 19, 2015

I wish the STL would just export an Either :(

@pthariensflame
Copy link
Member

Me too. There must be at least a few dozen radars about it now, right?

@CodaFi
Copy link
Member Author

CodaFi commented Nov 27, 2015

In light of recent events, I'm abandoning this effort. Hopefully @exported stabilizes or Swift gets an Either.

@CodaFi CodaFi closed this Nov 27, 2015
@CodaFi CodaFi deleted the dag-nabbit branch November 27, 2015 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy Clashes with Swiftz
2 participants
@CodaFi @pthariensflame