Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor handling of timeouts when trying to send messages with large attachments #33

Open
astiskala opened this issue Feb 4, 2018 · 0 comments

Comments

@astiskala
Copy link

Hi There,

I have been seeing timeouts in some cases when a message has many attachments. The timeouts surface themselves as a NullReferenceException as such:

System.NullReferenceException: Object reference not set to an instance of an object. at Typesafe.Mailgun.Http.MailgunHttpResponse.ReadJson() at Typesafe.Mailgun.Http.MailgunHttpRequest.GetResponse() at Typesafe.Mailgun.MailgunCommand1.Invoke()`

I believe it would be best if the library threw either a standard web exception or something more explicit in these cases.

It would also be good to be able to set a custom timeout value on the MailgunClient to override the default.

I'd be happy to put together a PR for this if you're accepting changes.

  • Adam
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant