Skip to content
This repository has been archived by the owner on Apr 11, 2022. It is now read-only.

Missing important npm subcommands #28

Open
Enet4 opened this issue Jun 30, 2021 · 3 comments · Fixed by sbt/sbt-js-engine#92
Open

Missing important npm subcommands #28

Enet4 opened this issue Jun 30, 2021 · 3 comments · Fixed by sbt/sbt-js-engine#92

Comments

@Enet4
Copy link

Enet4 commented Jun 30, 2021

It appears that Npm only provides the update subcommand, but the currently maintained versions of npm (v6 and v7) support other important commands. Namely:

  • install is the preferred subcommand for preparing a project to be used, installing any missing modules and running preparation scripts.
  • ci also works for this purpose, creating a fresh node_modules folder each time and checking that the package-lock is consistent with the package.json.

This has been brought up in sbt/sbt-js-engine#51, which would benefit from calling npm install instead of npm update.

If there is something that I can do to assist in this matter, I would be glad to know. My main limitation is that I'm fairly inexperienced in Scala.

@mkurz
Copy link

mkurz commented Jul 12, 2021

@Enet4 Do you think you are able to provide a pull request?

@Enet4
Copy link
Author

Enet4 commented Jul 12, 2021

Yes, I will try, @mkurz. But from what I could gather, the existing tests do not pass in the current revision (#27). It might be worth fixing this before admitting any new features.

@mkurz
Copy link

mkurz commented Jul 12, 2021

Yeah, unfortunately right now I don't have much time... Maybe in a couple of weeks or month I can work on that...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants