From 733b5e4fdd27eb0eaaff59f72c497ec21ccdcd5b Mon Sep 17 00:00:00 2001 From: Hayden Hung Hoang <94696449+phiHero@users.noreply.github.com> Date: Fri, 11 Oct 2024 15:30:43 +0700 Subject: [PATCH] fix build: `action` and `dirty_values` import parameters (#70) --- src/main/java/org/typesense/api/Documents.java | 4 ++-- src/test/java/org/typesense/api/DocumentsTest.java | 13 +++++++------ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/main/java/org/typesense/api/Documents.java b/src/main/java/org/typesense/api/Documents.java index 03509d4..f4a7540 100644 --- a/src/main/java/org/typesense/api/Documents.java +++ b/src/main/java/org/typesense/api/Documents.java @@ -10,10 +10,10 @@ import org.typesense.model.DeleteDocumentsParameters; import org.typesense.model.ExportDocumentsParameters; import org.typesense.model.ImportDocumentsParameters; +import org.typesense.model.IndexAction; import org.typesense.model.SearchParameters; import org.typesense.model.SearchResult; import org.typesense.model.UpdateDocumentsParameters; -import org.typesense.model.ImportDocumentsParameters.ActionEnum; public class Documents { @@ -43,7 +43,7 @@ public String create(Map document, ImportDocumentsParameters que public Map upsert(Map document) throws Exception { ImportDocumentsParameters queryParameters = new ImportDocumentsParameters(); - queryParameters.action(ImportDocumentsParameters.ActionEnum.UPSERT); + queryParameters.action(IndexAction.UPSERT); return this.apiCall.post(getEndPoint("/"), document, queryParameters, Map.class); } diff --git a/src/test/java/org/typesense/api/DocumentsTest.java b/src/test/java/org/typesense/api/DocumentsTest.java index 4f4fe06..4a51319 100644 --- a/src/test/java/org/typesense/api/DocumentsTest.java +++ b/src/test/java/org/typesense/api/DocumentsTest.java @@ -15,13 +15,14 @@ import org.typesense.api.exceptions.ObjectNotFound; import org.typesense.model.CollectionSchema; import org.typesense.model.DeleteDocumentsParameters; +import org.typesense.model.DirtyValues; import org.typesense.model.ExportDocumentsParameters; import org.typesense.model.Field; import org.typesense.model.ImportDocumentsParameters; +import org.typesense.model.IndexAction; import org.typesense.model.SearchParameters; import org.typesense.model.SearchResult; import org.typesense.model.UpdateDocumentsParameters; -import org.typesense.model.ImportDocumentsParameters.ActionEnum; class DocumentsTest { @@ -183,7 +184,7 @@ void testImport() throws Exception { documentList.add(document1); documentList.add(document2); - queryParameters.action(ImportDocumentsParameters.ActionEnum.CREATE); + queryParameters.action(IndexAction.CREATE); String countriesImport = this.client.collections("books").documents() .import_(documentList, queryParameters); @@ -193,7 +194,7 @@ void testImport() throws Exception { @Test void testImportAsString() throws Exception { ImportDocumentsParameters queryParameters = new ImportDocumentsParameters(); - queryParameters.action(ImportDocumentsParameters.ActionEnum.CREATE); + queryParameters.action(IndexAction.CREATE); String documentList = "{\"countryName\": \"India\", \"capital\": \"Washington\", \"gdp\": 5215}\n" + "{\"countryName\": \"Iran\", \"capital\": \"London\", \"gdp\": 5215}"; String booksImport = this.client.collections("books").documents().import_(documentList, @@ -216,8 +217,8 @@ void testDirtyCreate() throws Exception { helper.createTestDocument(); ImportDocumentsParameters queryParameters = new ImportDocumentsParameters(); - queryParameters.dirtyValues(ImportDocumentsParameters.DirtyValuesEnum.COERCE_OR_REJECT); - queryParameters.action(ImportDocumentsParameters.ActionEnum.UPSERT); + queryParameters.dirtyValues(DirtyValues.COERCE_OR_REJECT); + queryParameters.action(IndexAction.UPSERT); String[] authors = { "shakspeare", "william" }; HashMap hmap = new HashMap<>(); @@ -247,7 +248,7 @@ void testNestedObjectImport() throws Exception { client.collections().create(collectionSchema); ImportDocumentsParameters queryParameters = new ImportDocumentsParameters(); - queryParameters.action(ImportDocumentsParameters.ActionEnum.CREATE); + queryParameters.action(IndexAction.CREATE); List docs = new ArrayList<>(); NestedDocument doc = new NestedDocument("LA", "CA", "USA")