Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to invert method refactorings due to parameter refactorings #4

Open
max-ellis opened this issue May 9, 2022 · 0 comments
Open

Comments

@max-ellis
Copy link
Collaborator

We cannot invert a method level refactoring when a parameter level refactoring happens to a method signature in the commit history after that method is refactored. This happens because the method refactoring object created by RefactoringMiner is not updated when the parameter level refactoring happens.

Solution:

Add coverage for parameter refactorings. Alternatively, add overage for the simplification logic for parameter level refactorings and add support for invert/replay parameter refactorings later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant