Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking #41

Open
snadi opened this issue May 13, 2019 · 1 comment
Open

Benchmarking #41

snadi opened this issue May 13, 2019 · 1 comment

Comments

@snadi
Copy link
Contributor

snadi commented May 13, 2019

Initially, I thought that we cannot do precision with our benchmark since there may still be useful sentences we don't know about. Thus, a sentence we mark as false positive since it doesn't exist in our benchmark may still be a "good" sentence.

However, I realize this is actually not true. We looked at all if sentences in the threads we analyzed. Thus, we can calculate both precision and recall accurately. We cannot say those are the only useful sentences, but we can say those are the only useful if sentences. Thus, the low numbers we are getting means we were not doing that well in the first place.

I need to look at this a bit more and see what we did while in DysDoc https://docs.google.com/spreadsheets/d/17_76WimA6MyQ2LSVNdHXHIzFaubTeDMhpFOXI3u_wBw/edit#gid=0

@snadi
Copy link
Contributor Author

snadi commented May 13, 2019

As a test, add heuristic 0 which is any if sentence. This should give perfect recall and precision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant