Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap #3366

Open
ConnorSheremeta opened this issue Feb 2, 2024 · 1 comment
Open

Upgrade Bootstrap #3366

ConnorSheremeta opened this issue Feb 2, 2024 · 1 comment

Comments

@ConnorSheremeta
Copy link
Contributor

A bootstrap upgrade to at least 5.3.2 (currently on 4.6.2) is required to resolve this deprecation warning (https://blog.getbootstrap.com/2023/09/14/bootstrap-5-3-2/).

DEPRECATION WARNING: Passing percentage units to the global abs() function is deprecated.
In the future, this will emit a CSS abs() function to be resolved by the browser.
To preserve current behavior: math.abs(100%)
To emit a CSS abs() now: abs(#{100%})
More info: https://sass-lang.com/d/abs-percent

╷
│   $dividend: abs($dividend);
│              ^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/vendor/_rfs.scss 54:14             divide()
node_modules/bootstrap/scss/mixins/_grid.scss 66:15            row-cols()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 43:13  @content
node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5      media-breakpoint-up()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 32:5   make-grid-columns()
#node_modules/bootstrap/scss/_grid.scss 72:3                    @import
bootstrap/scss/bootstrap.scss 16:9                             @import
app/assets/stylesheets/application.sass.scss 7:9               root stylesheet
@ConnorSheremeta
Copy link
Contributor Author

I imagine that this upgrade will break some front-end components and will require following the upgrade guide followed by extensive testing.

From @jefferya on slack regarding a CVE which this upgrade (or an upgrade to 5.x.x) resolves:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant