Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Asset precompile step in CI test runner once on Rails 7.1 #3389

Closed
murny opened this issue Feb 24, 2024 · 1 comment
Closed

Simplify Asset precompile step in CI test runner once on Rails 7.1 #3389

murny opened this issue Feb 24, 2024 · 1 comment
Assignees
@murny

Comments

@murny
Copy link
Contributor

murny commented Feb 24, 2024

From this discussion thread, I added a test:prepare step to our CI runner to precompile the assets for test: https://github.com/ualbertalib/jupiter/pull/3320/files#r1485209880

In Rails 7.1 this shouldn't be necessary anymore: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#bin-rails-test-now-runs-test-prepare-task

Let's make this change once webpack migration PR gets merged to #3346 so we don't forget.
@murny murny self-assigned this Feb 24, 2024
@murny murny mentioned this issue Mar 5, 2024
Merged
@murny
Copy link
Contributor Author

murny commented Mar 12, 2024

This is in master now

@murny murny closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murny murny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murny