Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 Foundational choices and their influence on design/coding choices #190

Open
williamdemeo opened this issue Apr 24, 2022 · 5 comments
Open
Assignees

Comments

@williamdemeo
Copy link
Member

(The 1.3 label in the title of this issue is a reference to point 3 from the 1st referee report.)

In the introduction (e.g. 3rd ¶) and §2.1, we claim to take great care with foundational aspects. Further explanation of the following would make clearer the relevance of our work:

  • (a) How does this attention to foundational details affect our coding choices?
  • (b) What's the difference from the foundational view-point between our code and work cited in sect.7?
  • (c) At start of §2.2, our claims about setoids seem a bit bold (or "gnomic"). We don't cite work on the so-called "setoid hell", and we miss the point of the bad reputation of setoids. Referee asserts: setoids do not make implementation tedious, but, in a sense, unnatural wrt informal mathematical practice, since any setoid-based reasoning depends on specific implementation details. Some parts of our code (omitted from the paper) suffer from these aspects of using setoids.

(wd: I made an first attempt to address point c in the latest PR)

@JacquesCarette
Copy link
Collaborator

Ack. that this is on my plate.

@JacquesCarette
Copy link
Collaborator

Hmm, I'm not quite sure where I should discuss this. Also "any setoid-based reasoning depends on specific implementation details" is not something I believe is true! I'm not going to address that bit at all, as I'd need an example. Lastly, I have no idea what work to cite wrt this.

@williamdemeo
Copy link
Member Author

You are mildly alarmed or dismayed that this is on your plate? (I had to look up "Ack" :)

Fair enough. I think what you said in your second comment is reasonable. I suspect we could get away with saying something like that in our response to the referees in order to justify leaving the paper as is (with respect to this).

@JacquesCarette
Copy link
Collaborator

I keep forgetting your main education is all math, so some oft-used CS lingo (like Ack as a short-form for aknowledged, which comes from low-level network protocols) is mysterious.

I am neither dismayed nor alarmed that this is on my plate. Once I looked into it some more, I came up empty-handed as to where to actually address it! I'd be happy to only address in referee response.

JacquesCarette added a commit to JacquesCarette/agda-algebras that referenced this issue Apr 26, 2022
williamdemeo added a commit that referenced this issue Apr 26, 2022
@williamdemeo
Copy link
Member Author

I was going to close this, but I'll leave it open, in case we want a reminder that JC's nice comments about this could go in Sec 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants