Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:#28 #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix:#28 #67

wants to merge 1 commit into from

Conversation

skooulhk
Copy link

@skooulhk skooulhk commented Mar 6, 2024

  • copyPath func refactor.
  • SimConfigs now updated and backuped on startup.

fix:uavos#28
7f69e60 
- copyPath func refactor.
- SimConfigs now updated and backuped on startup.
uavinda
uavinda requested changes Mar 6, 2024
View reviewed changes
src/lib/ApxData/Sharing/Share.cpp
AppDirs::configs().absoluteFilePath(""),
"vehicle",
AppDirs::configBackups().absoluteFilePath(""));
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share is a base class for other classes in different modules (Telemetry, Mission, etc) thus it's going to copy many times the same files on every ancessor object invocation.

I'd suggest to copy these telemetry samples in this constructor:

apx-gcs/src/lib/ApxGcs/Telemetry/Telemetry.cpp

Line 35 in 51539cc

Telemetry::Telemetry(Vehicle *parent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uavinda uavinda uavinda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skooulhk @uavinda