Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators for Fact #41

Open
smarttowel opened this issue Jul 9, 2019 · 7 comments
Open

Validators for Fact #41

smarttowel opened this issue Jul 9, 2019 · 7 comments
Assignees
@smarttowel
Labels
feature New feature or request

Comments

@smarttowel
Copy link
Member

smarttowel commented Jul 9, 2019 •
edited
Loading

Validators
@smarttowel smarttowel added the feature New feature or request label Jul 9, 2019
@smarttowel smarttowel changed the title UI improvements for Fact Validators for Fact Jul 9, 2019
@uavinda
Copy link
Member

uavinda commented Jul 9, 2019

Please, add more description to the problem.

@smarttowel
Copy link
Member Author

For example, we have TextInput for ip:port. We can make regexp validator for this format, so user immediately can see, valid input or not.

@uavinda
Copy link
Member

uavinda commented Jul 9, 2019

I think we should declare a new QString property for the Fact: validator. Then we must update qml FactButton editors, wherever they use TextInput - to support validator regex when present. Can you make it and propose the changes?

@uavinda
Copy link
Member

uavinda commented Jul 9, 2019

Don't forget to update FactObject.qml to support validator.

@uavinda
Copy link
Member

uavinda commented Jul 9, 2019

I just have to merge git-repos to master ASAP to continue releases.

@uavinda
Copy link
Member

uavinda commented Jul 11, 2019

Bump

@smarttowel smarttowel assigned smarttowel and unassigned uavinda Jul 11, 2019
@smarttowel
Copy link
Member Author

I will do it, when I have free time.
You can prepare release without this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarttowel smarttowel

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uavinda @smarttowel