Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources are sometimes stripped out in cromite for windows #1593

Open
uazo opened this issue Oct 22, 2024 · 1 comment
Open

Resources are sometimes stripped out in cromite for windows #1593

uazo opened this issue Oct 22, 2024 · 1 comment
Labels
bug Something isn't working task These are things I tell myself I should do

Comments

@uazo
Copy link
Owner

uazo commented Oct 22, 2024

In windows, the resources are contained in chrome.dll and there is something that deletes them if not referenced by the code.

in 130.0.6723.67, in fact, I get an error when searching for IDS_WEBSITE_SETTINGS_CATEGORY_POPUP_BLOCKED in ResourceBundle::GetLocalizedStringImpl() probably because it is included in the content settings, but never used directly in
PermissionToggleRowView::UpdateUiOnPermissionChanged()

I should figure out where the unused resource strip is, which I can't find.

@uazo uazo added bug Something isn't working task These are things I tell myself I should do labels Oct 22, 2024
uazo added a commit that referenced this issue Nov 7, 2024
@Metrokoto

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task These are things I tell myself I should do
Projects
None yet
Development

No branches or pull requests

2 participants