Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Add link from Teams panel to github user repos #7

Open
rtholmes opened this issue Sep 16, 2016 · 4 comments
Open

Add link from Teams panel to github user repos #7

rtholmes opened this issue Sep 16, 2016 · 4 comments
Assignees

Comments

@rtholmes
Copy link
Contributor

The 'repos' button from #3 was super awesome. It would be great if the students could check if their team mates had registered as well. In the Teams panel for the student view, could the button change to the same style as for the 'repos' button if the teammate has their github username registered? Tapping on the button should take them to the github user page. Since the student checking will already be registered their own button will always show as a button that they can tap to go to their page too.

It would be good to extend #3 by making the repo button look disabled if the link hasn't been set yet.

@mksarge
Copy link
Contributor

mksarge commented Sep 16, 2016

I'll look into this over the weekend. Perhaps something like:

displayteam

@mksarge mksarge self-assigned this Sep 16, 2016
@rtholmes
Copy link
Contributor Author

I'm assuming the Team3 / Teammate1 / Teammate 2 things are all just depressed buttons right? I think you could just have those three buttons, and if they exist (aka the repo exists for the team, or the users are registered in github) they turn to actual pressable buttons, otherwise they are just in the depressed state. That way you don't actually need the repo ones beside?

@mksarge
Copy link
Contributor

mksarge commented Sep 16, 2016

Yes, they're unselectable/unclickable forms. I could definitely do it the way you described, probably in 1 line like the Button Groups in elemental-ui.com/buttons.

@rtholmes
Copy link
Contributor Author

The button group would work in this case with only two members, but if you had 8 people it might be too much. Individual buttons arranged vertically might be safer (and work better on mobile).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants