Organize the arguments of Model.render. #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidepelican
commented
Nov 6, 2024
| } | ||
| return nil | ||
| } | ||
| .sorted { (left: (String, Int64), right: (String, Int64)) -> Bool in |
There was a problem hiding this comment.
The sorting is done in generateUniqueModels, so sorting here is unnecessary.
| @@ -32,28 +31,37 @@ final class ClosureModel: Model { | |||
| return .closure | |||
| } | |||
|
|
|||
| init(genericTypeParams: [ParamModel], paramNames: [String], paramTypes: [SwiftType], isAsync: Bool, throwing: ThrowingKind, returnType: SwiftType, encloser: String) { | |||
There was a problem hiding this comment.
encloser is unnecessary here because type depends on RenderContext.
| @@ -27,6 +27,18 @@ public enum ModelType { | |||
| case closure | |||
| } | |||
|
|
|||
| enum NominalTypeDeclKind: String { | |||
There was a problem hiding this comment.
In the most places, DeclType has incorrect cases so prepares new enum.
fummicc1
reviewed
Nov 10, 2024
Co-authored-by: Fumiya Tanaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model.renderhas a lot of arguments, making it very complex.There are also places where meaningless values are being passed.
In this PR, I will organize the arguments by separating them into
RenderContextandGenerationArguments, allowing us to distinguish between global settings and the state during the render process.