-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize the arguments of Model.render. #272
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bf215ca
Cleanup render function arguments
sidepelican 5bdc155
Use Algorithms
sidepelican 64f57fa
Remove unnecessary default value
sidepelican de68c4c
Add test case about known issue
sidepelican 7676296
Fix consistency when context state is not correct
sidepelican 7f3bc87
remove unnecessary init argument
sidepelican a24f9f6
Use NominalTypeDeclKind instead of FindTargetDeclType in most places
sidepelican 6afc544
Use XCTExpectFailure in macOS
sidepelican f051257
Avoid force unwrapping and keep consistency
sidepelican e399b0e
Update Sources/MockoloFramework/Models/TypeAliasModel.swift
sidepelican File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,18 @@ public enum ModelType { | |
case closure | ||
} | ||
|
||
enum NominalTypeDeclKind: String { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the most places, |
||
case `class` | ||
case `actor` | ||
case `protocol` | ||
} | ||
|
||
struct RenderContext { | ||
var overloadingResolvedName: String? | ||
var enclosingType: SwiftType? | ||
var annotatedTypeKind: NominalTypeDeclKind? | ||
} | ||
|
||
/// Represents a model for an entity such as var, func, class, etc. | ||
protocol Model: AnyObject { | ||
/// Identifier | ||
|
@@ -45,14 +57,9 @@ protocol Model: AnyObject { | |
var offset: Int64 { get } | ||
|
||
/// Applies a corresponding template to this model to output mocks | ||
func render(with identifier: String, | ||
encloser: String, | ||
useTemplateFunc: Bool, | ||
useMockObservable: Bool, | ||
allowSetCallCount: Bool, | ||
mockFinal: Bool, | ||
enableFuncArgsHistory: Bool, | ||
disableCombineDefaultValues: Bool | ||
func render( | ||
context: RenderContext, | ||
arguments: GenerationArguments | ||
) -> String? | ||
|
||
/// Used to differentiate multiple entities with the same name | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encloser
is unnecessary here becausetype
depends onRenderContext
.