User provided node_name_mapping
is not used with TF SavedModels
#550
Labels
good first issue
Good for newcomers
node_name_mapping
is not used with TF SavedModels
#550
Context
The user provided
node_name_mapping
is not used when running TF SavedModels. It's only used when running TF frozen graphs.TF SavedModels have
SignaureDef
s. These are quite similar to whatnode_name_mapping
is in Neuropod.Since SavedModel already has this functionality (and other projects like TF serving use it), it made sense to use that data as the node name mapping. Otherwise we’d either have to support mappings in both TF
SignatureDef
s and Neuropod or just Neuropod. The latter is not ideal and the former wasn't necessary for our initial SavedModel usecase.Unfortunately, this not documented anywhere in
create_tensorflow_neuropod
and the docs are even a little misleading:neuropod/source/python/neuropod/backends/tensorflow/packager.py
Lines 41 to 52 in b18e281
Expected behavior
We should do the following:
node_name_mapping
is not supported when using a SavedModel and that users should use TF SignaureDefs instead for that functionality.node_name_mapping
is provided when packaging a SavedModelAlternatively, we could add support for
node_name_mapping
with SavedModels, but we should decide whether that's behavior we want.The text was updated successfully, but these errors were encountered: