Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Add ability to annotate messages/fields with nolint directive #547

Open
jared2501 opened this issue Mar 29, 2020 · 2 comments
Open

Add ability to annotate messages/fields with nolint directive #547

jared2501 opened this issue Mar 29, 2020 · 2 comments
Labels
feature New feature or request

Comments

@jared2501
Copy link

I have some enums/structs that fail lint in my protobuf, for good reason (e.g. I have an enum called X509_KEY_USAGE_DATA_ENCIPHERMENT, and "data encipherment is a phrase taken from IETF spec).

Currently, i skip the entire file by adding it to my prototool.yaml. Instead, I would like to be able to annotate this enum, or even this value in the enum, with a comment that would disable linting for this specific case. golangci-lint offers a // nolint:<rule-name> directive which I find super handy in cases like these. Can prototool learn this skill too?

@smaye81 smaye81 added the feature New feature or request label Mar 31, 2020
@smaye81
Copy link
Contributor

smaye81 commented Mar 31, 2020

Yeah this is a fair request. I will add it to the backlog.

@sysulq
Copy link

sysulq commented Nov 17, 2021

looking forward to this new feature!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants