Fixed bug with inApp authentication #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The consumer apps can use different authentication mechanisms to authenticate against Uber - using an Uber app or using inApp flow (leveraging custom tabs). We use the same app link for both forms of authentication
Issue
If the authentication flow is chosen as
inAppbut there's an Uber app installed that is capable of intercepting the app link then it is possible that in the middle of theinAppflow an Uber app gets launched due to a redirect from the web.Fix
For
inAppflow we use a different url from the url for Uber app sso flow. For sso the path isoauth/v2/universal/authorizebut forinAppthe path isoauth/v2/authorize. This ensures that no app can intercept the redirect from the web and user can successfully complete the flow on web.