-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to compile on FreeBSD 14: missing function getSendQueueLen #914
Labels
Comments
moonetic
added a commit
to moonetic/tchannel-go
that referenced
this issue
Oct 31, 2024
This PR fixes compilation fail on FreeBSD 14, described on [issue by hxw](uber#914) The problem is, that there's no getSendQueueLen function defined for bsd platform, which causes compile failure. The fix adds new, sockio_bsd file with corresponding function implementation and build tags.
moonetic
added a commit
to moonetic/tchannel-go
that referenced
this issue
Nov 7, 2024
This PR fixes compilation fail on FreeBSD 14, described on [issue by hxw](uber#914) The problem is, that there's no getSendQueueLen function defined for bsd platform, which causes compile failure. The fix adds new, sockio_bsd file with corresponding function implementation and build tags.
cinchurge
pushed a commit
that referenced
this issue
Dec 17, 2024
This PR fixes compilation fail on FreeBSD 14, described on [issue by hxw](#914) The problem is, that there's no getSendQueueLen function defined for bsd platform, which causes compile failure. The fix adds new, sockio_bsd file with corresponding function implementation and build tags.
moonetic
added a commit
to moonetic/tchannel-go
that referenced
this issue
Dec 19, 2024
This PR fixes compilation fail on FreeBSD 14, described on [issue by hxw](uber#914) The problem is, that there's no getSendQueueLen function defined for bsd platform, which causes compile failure. The fix adds new, sockio_bsd file with corresponding function implementation and build tags.
moonetic
added a commit
to moonetic/tchannel-go
that referenced
this issue
Dec 19, 2024
This PR fixes compilation fail on MacOS(darwin), that occurrs after fixing the FreeBSD 14 compile issue described on [issue by hxw](uber#914) The problem is, that now there are two getSendQueueLen functions defined for darwin platform, which causes compile failure. The fix removes darwin build tag from sockio_bsd file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Quick Fix
There is a
sockio_unix.go
which shows support for many OSs, but it references a getSendQueueLen function.Currently this function is only defined for Linux (in sockio_linux.go). A quick fix for FreeBSD is to:
Next patch the sockio_bsd.go with the following diff:
Better Alternative (perhaps)
Alternatively the function using
unix.TIOCOUTQ
could just be added tosockio_unix.go
and thesockio_linux.go
removed. From inspection of the files ingo120/src/cmd/vendor/golang.org/x/sys/unix/
- All the OSs supported bysockio_unix.go
have theTIOCOUTQ
IOCTL and in the various Linux files this has exactly the same as theSIOCOUTQ
value.The text was updated successfully, but these errors were encountered: