fix: initialize admin_hash empty

ubi-agni · Dec 5, 2024 · 9aae6c9 · 9aae6c9
1 parent 1f42d1c
commit 9aae6c9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/mujoco_ros/include/mujoco_ros/mujoco_env.h b/mujoco_ros/include/mujoco_ros/mujoco_env.h
@@ -193,8 +193,8 @@ class MujocoEnv
 		int busywait        = 0;
 
 		// Mode
-		bool eval_mode = false;
-		char admin_hash[64];
+		bool eval_mode      = false;
+		char admin_hash[64] = "\0";
 
 		// Atomics for multithread access
 		std::atomic_int run                 = { 0 };

diff --git a/mujoco_ros/src/mujoco_env.cpp b/mujoco_ros/src/mujoco_env.cpp
@@ -90,6 +90,9 @@ MujocoEnv::MujocoEnv(const std::string &admin_hash /* = std::string()*/)
 	if (!admin_hash.empty()) {
 		ROS_WARN("Hash not empty");
 		mju::strcpy_arr(settings_.admin_hash, admin_hash.c_str());
+	} else {
+		// make sure hash is empty and null-terminated
+		settings_.admin_hash[0] = '\0';
 	}
 
 	ROS_WARN("Getting eval mode...");