Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix: Automatic Assign on Opened Pull Request (Assigned to Unrelated Task!) #34

Closed
0x4007 opened this issue Aug 9, 2023 · 15 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Aug 9, 2023

I was working on ubiquity/ubiquibot#595 and opened up a few pull requests because I need to change several repositories' UbiquiBot configs. After opening up my third pull request ubiquity/ubiquity-dollar#751 I was assigned to an unrelated issue: ubiquity/ubiquity-dollar#595

I assume this has something to do with the fact that the issue number (595) is the same across both repositories. Perhaps the feature did not accomodate for cross repository issue tracking. Please diagnose and fix.

@0x4007
Copy link
Member Author

0x4007 commented Aug 9, 2023

@wannacfuture you're great at hot fixes is this interesting for you?

@wannacfuture wannacfuture self-assigned this Aug 9, 2023
@wannacfuture wannacfuture changed the title Automatic Assign on Opened Pull Request (Assigned to Unrelated Task!) Hot fix: Automatic Assign on Opened Pull Request (Assigned to Unrelated Task!) Aug 9, 2023
@wannacfuture
Copy link
Collaborator

/help

@ubiquibot
Copy link

ubiquibot bot commented Aug 9, 2023

Available commands

- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@ubiquibot
Copy link

ubiquibot bot commented Aug 14, 2023

Do you have any updates @wannacfuture? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

@ubiquibot
Copy link

ubiquibot bot commented Aug 17, 2023

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

@wannacfuture wannacfuture self-assigned this Aug 17, 2023
@ubiquibot
Copy link

ubiquibot bot commented Aug 17, 2023

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Wed Aug 09 2023 23:57:36 GMT+0000 (Coordinated Universal Time)

@wannacfuture
Copy link
Collaborator

let me handle this. Mr.Bot!

@wannacfuture wannacfuture self-assigned this Aug 17, 2023
@wannacfuture
Copy link
Collaborator

wannacfuture commented Aug 17, 2023

Hmmm, while investigating this issue some quick questions for you, @pavlovcik
Your example pull request says it will resolve an issue on another repo.

Of course it will be possible to assigne pr opener to other repo's issue forcely.
But I'm not too sure if its right behaviour.

lets assume that we opened the pr and it says it will resolve an issue on other repo(this repo hasn't installed our bot)
we will assignee the pr opener to that issue.
But maybe the repo owner doesn't want to assignee people to his issue automatically.

Also, technically speaking, to assignee the hunter to other repo's issue we will need that repo's owner name or something(maybe it can be possible if we do more research about octokit).
image

I may be wrong. RFC

@wannacfuture
Copy link
Collaborator

So, IMO, we should check if the pr is trying to resolve the issue on the same repo or other repo of same orgnization then automatically assign the pr opener to the issue.

rfc, @pavlovcik

@0x4007
Copy link
Member Author

0x4007 commented Aug 17, 2023

But maybe the repo owner doesn't want to assignee people to his issue automatically

Not possible the bot wouldn't have permissions to

@ubiquibot
Copy link

ubiquibot bot commented Aug 23, 2023

Do you have any updates @wannacfuture? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Thu Aug 17 2023 02:53:11 GMT+0000 (Coordinated Universal Time)

@0x4007
Copy link
Member Author

0x4007 commented Aug 24, 2023

I will start posting all of these fixes on the @ubiquity/ubiquibot repository in the future. I can't easily transfer this one now.

@ubiquibot
Copy link

ubiquibot bot commented Aug 24, 2023

@wannacfuture - Releasing the bounty back to dev pool because the allocated duration already ended!
Last activity time: Thu Aug 17 2023 02:53:11 GMT+0000 (Coordinated Universal Time)

@ubiquibot
Copy link

ubiquibot bot commented Aug 24, 2023

Permit generation skipped because the issue was not closed as completed

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

@0x4007
Copy link
Member Author

0x4007 commented Aug 24, 2023

Moved to ubiquity/ubiquibot#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants