-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix entity too large error #15
Comments
I just downloaded the action run logs to investigate.
|
Beyond the lock files the main issue were the dist compiled js files that are 15 mb of size and millions of characters that ended up in the diff. These should be somehow ignored. |
ahh I didn't scan each line or review the PRs, I keyword searched sources of info and made assumptions as to what was in the PRs exactly but that's a good idea. Removing sections from the diff is not a trivial task I have spent a couple hours on it but I could never get it perfect. But effectively, without a solve for this plus unlimited fetch depth, this may become an often recurring error. |
Some standardized strategies We can use .gitignore and also linguist. I suppose for partner convenience we can try and intelligently exclude some things like reading the out directory in tsconfig and excluding? Perhaps there is an open source tool who already figured this out for us. |
This issue should be resolved in Pull #21. I've created a new package that allows us to fetch diffs based on file paths and glob patterns, enabling us to filter diffs by the number of changes and file extensions as well. |
! 413 Request Entity Too Large
Originally posted by @ubiquity-os-beta[bot] in ubiquity-os-marketplace/text-conversation-rewards#163 (comment)
@sshivaditya2019 RFC
The text was updated successfully, but these errors were encountered: