Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Task Assignment Limit Handling #106

Open
0x4007 opened this issue Dec 13, 2024 · 27 comments
Open

Improve Task Assignment Limit Handling #106

0x4007 opened this issue Dec 13, 2024 · 27 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Dec 13, 2024

Problem
Contributors are blocked from assigning new tasks due to the current task limit, even when they’ve addressed all open review threads and are waiting on reviewers. This bottleneck discourages contributors and slows down productivity.

Proposed Solution

  1. Add logic to check if the assignee is the last commenter on all unresolved review threads.1
  2. Introduce a 24-hour timeout after the last comment before considering tasks "reviewer-lagged."
  3. Allow contributors to bypass the limit in such cases without affecting their task slots.

Concerns

  • Assignees might misuse this by "resolving" threads without addressing the issues.
  • Additional safeguards may be needed to ensure resolution integrity.

References

  • Original comment thread: #100.

Footnotes

  1. ⚠ 50% possible duplicate - Improve Task Limiter

Copy link

ubiquity-os-beta bot commented Dec 13, 2024

Note

The following contributors may be suitable for this task:

gentlementlegen

0% Match ubiquity-os-marketplace/daemon-pricing#47

0x4007

0% Match ubiquity/work.ubq.fi#125

@jordan-ae
Copy link
Contributor

/start

Copy link

Deadline Fri, Dec 13, 4:09 PM UTC
Beneficiary 0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

2 similar comments
Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

9 similar comments
Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @jordan-ae.

@Sadaf-A
Copy link

Sadaf-A commented Dec 16, 2024

/start

Copy link

Deadline Mon, Dec 16, 8:11 AM UTC
Beneficiary 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

Passed the disqualification threshold and no activity is detected, removing assignees: @Sadaf-A.

@gentlementlegen
Copy link
Member

The 24 hour delay is already implemented. How do you believe a bypass can safely be implemented for contributors? Also, the last comment being the user can be implemented but most likely will make the command slow and unresponsive, maybe too slow to run on Workers.

@0x4007
Copy link
Member Author

0x4007 commented Dec 20, 2024

The 24 hour delay is already implemented. How do you believe a bypass can safely be implemented for contributors?

Unfortunately, the best idea I have requires using an LLM to read the thread and see if the changes were implemented. Seems a bit much, but I can't see how else it would be possible to determine if the problem was actually resolved.

Also, the last comment being the user can be implemented but most likely will make the command slow and unresponsive, maybe too slow to run on Workers.

This can be a problem, but I would imagine that contributors should not have more than two pull requests open. It's not that much data, so maybe it's not so slow?

@Sadaf-A
Copy link

Sadaf-A commented Dec 21, 2024

/start

1 similar comment
@gentlementlegen
Copy link
Member

/start

Copy link

Deadline Sat, Dec 21, 12:36 PM UTC
Beneficiary 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@gentlementlegen
Copy link
Member

/stop

@Sadaf-A
Copy link

Sadaf-A commented Dec 21, 2024

/start

Copy link

! You do not have the adequate role to start this task (your role is: member). Allowed roles are: collaborator, admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants