Do not close pull-requests linked to an issue with no price tag

[gentlementlegen]

          I think it basically should be disabled in respect to automations for normal GitHub issues without pricing. Then it won't get in the way for partners easing into using the system

Originally posted by @0x4007 in ubiquity-os/ubiquity-os-kernel#234 (comment)

What happened

The pull-request that was linked to the issue got closed because the related issue had no price tag set.

What was expected

The pull-request should not get closed when the price label is missing.

How to reproduce

• create an issue with no price tag, only time estimate for example
• link a pull-request that would close it (Resolves #)
• notice that the pull-request gets closed by the bot

[gentlementlegen]

/start

[ubiquity-os-beta]

Beneficiary

0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED

Tip

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

[ubiquity-os-beta]

Important

• Be sure to link a pull-request before the first reminder to avoid disqualification.
• Reminders will be sent every 3 days and 12 hours if there is no activity.
• Assignees will be disqualified after 7 days of inactivity.

[gentlementlegen]

@0x4007 Would it be preferable to:

• keep this behavior for contributor and let collaborators / admin override it (contributors linking pull-requests to unpriced would be closed)
• totally get rid of checks whenever pricing is missing

The first option seems to make more sense maybe?

[0x4007]

/ask rewrite/explain/reiterate the first bullet point because I don't quite understand.

The term contributor refers to an outside contributor. We use the term collaborator for anybody added to our organization or repo as a team member.

keep this behavior for contributor and let collaborators / admin override it (contributors linking pull-requests to unpriced would be closed)

[0x4007]

The first option seems to make more sense maybe?

I'm inclined to go with your judgement but not quite understanding how that looks in practice.

[ubiquity-os-beta]

! An error occurred

[0x4007]

! An error occurred

@shiv810

[0x4007]

/ask rewrite/explain/reiterate the first bullet point because I don't quite understand.

The term contributor refers to an outside contributor. We use the term collaborator for anybody added to our organization or repo as a team member.

keep this behavior for contributor and let collaborators / admin override it (contributors linking pull-requests to unpriced would be closed)

[ubiquity-os-beta]

Certainly! Let me clarify the first bullet point for you:

Original Bullet Point:

keep this behavior for contributor and let collaborators / admin override it (contributors linking pull-requests to unpriced would be closed)

Rewritten Explanation:

• Contributors (External Contributors):

  • Behavior: If an external contributor links a pull request (PR) to an issue that does not have a price tag, the system will automatically close that PR.
  • Reason: This ensures that contributions are aligned with issues that have defined priorities or budgets, maintaining project focus and resource allocation.

• Collaborators and Administrators (Internal Team Members):

  • Override Capability: Members who are part of the organization (collaborators) or have administrative privileges can override this automatic closing behavior.
  • Flexibility: This allows internal team members to link PRs to unpriced issues when necessary, providing flexibility for tasks that may not yet have a defined price or for exploratory work.

In Summary:

• External Contributors: Their PRs linking to issues without a price tag will be automatically closed to ensure alignment with prioritized tasks.
• Internal Collaborators/Admins: They have the authority to bypass this restriction, allowing PRs to remain open even if linked to unpriced issues when deemed appropriate.

This approach maintains project structure and prioritization for external contributions while providing internal team members the flexibility to manage tasks as needed.

[gentlementlegen]

That is pretty much correct, the idea is that if you wanna allow contributors to link pull-requests and get assigned to issues that have no pricing or not.

[0x4007]

I'm not sure why I'm having difficulties wrapping my head around the full picture here. Maybe I'm getting sick now.

I just hope we don't have a situation where we have hanging open pulls that are forgotten about (this used to happen a lot)

So either we have follow ups, auto merges, or something else.

[gentlementlegen]

Current issue:

• if a user links a pull-request to an issue that is not priced, that issues get closed instantly. This is a problem when we are solving tasks that are not priced
• this happens for admins, collaborators, contributors

Changes proposed:

• EITHER disabled the pull-request closing automatically on un priced tasks for everyone (anyone could link PRs on issues that do not have a price tag)
• OR allow this capability only for collaborators / admins

Side note:
You had previously asked me to not run the reminders on unpriced tasks, so unpriced tasks don't get follow ups.

[0x4007]

Let's do what you want to do and observe when it's running