-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto merge if all requested reviews are approved #5
Comments
We could consider having the plugin going through every repo and set the settings accordingly. Does this support giving delays as we do (wait for 7 days for example) and different rules based on the rule of the pull-request author? |
This seems useful too. I just don't want to be rebuilding the features that GitHub already has of course!
Sure if we can inherit this from the already implemented logic! |
I will look more in details about GitHub capabitlities regarding this feature. What our plugin allows currently is:
If all of these are configurable within GitHub itself, let's transform the plugin to manipulate the configuration of each repo so we don't have to do it manually, because I agree that it is tedious. |
Mixed feelings on this because GitHub has this feature already, but it must be manually enabled per every repository which is tedious.
This seems like a simple example of when it can automatically merge with no risk:
ubiquity-os-marketplace/command-start-stop#18 (review)
At least our improvement should allow a threshold i.e. 2/3 requested reviews approved, so automatically merge.
The text was updated successfully, but these errors were encountered: