Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto merge if all requested reviews are approved #5

Open
0x4007 opened this issue Jul 29, 2024 · 3 comments
Open

Auto merge if all requested reviews are approved #5

0x4007 opened this issue Jul 29, 2024 · 3 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Jul 29, 2024

Mixed feelings on this because GitHub has this feature already, but it must be manually enabled per every repository which is tedious.

This seems like a simple example of when it can automatically merge with no risk:

ubiquity-os-marketplace/command-start-stop#18 (review)

At least our improvement should allow a threshold i.e. 2/3 requested reviews approved, so automatically merge.

@gentlementlegen
Copy link
Member

We could consider having the plugin going through every repo and set the settings accordingly. Does this support giving delays as we do (wait for 7 days for example) and different rules based on the rule of the pull-request author?

@0x4007
Copy link
Member Author

0x4007 commented Jul 29, 2024

Does this support giving delays as we do (wait for 7 days for example)

This seems useful too. I just don't want to be rebuilding the features that GitHub already has of course!

different rules based on the rule of the pull-request author?

Sure if we can inherit this from the already implemented logic!

@gentlementlegen
Copy link
Member

I will look more in details about GitHub capabitlities regarding this feature. What our plugin allows currently is:

  • check that it is mergeable
  • check that the CI run is ok
  • check for the delay based on the association of the user (collaborator, contributor)
  • check for any kind of activity

If all of these are configurable within GitHub itself, let's transform the plugin to manipulate the configuration of each repo so we don't have to do it manually, because I agree that it is tedious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants