-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated nonces #46
Duplicated nonces #46
Comments
The property name suggests issue ID not issue number. That would work. |
|
@0x4007 Still not possible to claim for me. |
I added another task to this list |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 50 |
Issue | Specification | 1 | 14.4 |
Review | Comment | 5 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Nonces for some github issues are duplicated hence reward claimi… | 14.4content: p: symbols: \b\w+\b: count: 20 multiplier: 0.1 score: 1 ul: symbols: \b\w+\b: count: 93 multiplier: 0.1 score: 0 li: symbols: \b\w+\b: count: 13 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 5 code: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 5 multiplier: 3 | 1 | 14.4 |
Resolves https://github.com/ubiquibot/permit-generation/issues/4… | 0content: p: symbols: \b\w+\b: count: 144 multiplier: 0 score: 1 code: symbols: \b\w+\b: count: 8 multiplier: 0 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0 score: 1 strong: symbols: \b\w+\b: count: 15 multiplier: 0 score: 0 ul: symbols: \b\w+\b: count: 78 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 18 multiplier: 0 score: 1 multiplier: 0 | 0.95 | - |
TLDR; We used issue number instead of `id` or `node_… | 0content: p: symbols: \b\w+\b: count: 18 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
I would use a particular version. Otherwise it's harder to debug… | 0content: p: symbols: \b\w+\b: count: 33 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
Updated https://github.com/ubiquibot/conversation-rewards/pull/1… | 0content: p: symbols: \b\w+\b: count: 11 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
https://github.com/ubiquibot/conversation-rewards/pull/108/commi… | 0content: p: symbols: \b\w+\b: count: 10 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
[ 8.5 WXDAI ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 1.2 |
Review | Comment | 4 | 7.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
The property name suggests issue ID not issue number. That would… | 1.2content: p: symbols: \b\w+\b: count: 12 multiplier: 0.1 score: 1 multiplier: 1 | 0.7 | 0.84 |
- I was able to claim https://github.com/ubiquity/ubiquibot-kern… | 1.8content: ul: symbols: \b\w+\b: count: 17 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 0.2 | 0.36 |
Let's always use latest. Otherwise looks good to me. | 1content: p: symbols: \b\w+\b: count: 10 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1 |
This still doesn't make sense to me why suddenly there are issue… | 2.2content: p: symbols: \b\w+\b: count: 22 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.2 |
```suggestion "@ubiquibot/permit-generation": "*… | 0.3content: pre: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 0.3 |
For now, I know that we can trace back the GitHub actions run so… | 3.8content: p: symbols: \b\w+\b: count: 38 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3.8 |
[ 9.14 WXDAI ]
@gentlementlegen
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 5.84 |
Review | Comment | 1 | 3.3 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Impacted rewards that I've seen so far: - [ ] https://github.co… | 7.1content: p: symbols: \b\w+\b: count: 8 multiplier: 0.1 score: 1 ul: symbols: \b\w+\b: count: 52 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 11 multiplier: 0.1 score: 1 multiplier: 1 | 0.8 | 5.68 |
@0x4007 Still not possible to claim for me. | 0.8content: p: symbols: \b\w+\b: count: 8 multiplier: 0.1 score: 1 multiplier: 1 | 0.2 | 0.16 |
I am against the use of the wildcard because it will break on ma… | 3.3content: p: symbols: \b\w+\b: count: 30 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 3 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3.3 |
[ 0.07 WXDAI ]
@Keyrxng
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.07 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
I added another task to this list | 0.7content: p: symbols: \b\w+\b: count: 7 multiplier: 0.1 score: 1 multiplier: 1 | 0.1 | 0.07 |
I will be regenerating the permits listed above and see if they are claimable now. I can confirm that after re-generating all claims worked. However I am afraid that these can be claimed twice from the people where it already worked before, so I deleted the results. |
Nonces for some github issues are duplicated hence reward claiming is broken for those issues.
Check the following reward URLs:
In the decoded base64 input all nonces (per user) are equal while the expected behavior is that they should be different.
It happens because here the nonce is derived from user's github id and github issue number while earlier (not sure when the code was updated) it'd been derived from
issue.node_id
.What should be done:
The text was updated successfully, but these errors were encountered: