Feat/fetch manifests #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
|
Might need to reopen this pull to exclude the template diff |
|
I pretty much abandoned my approach used in this PR but used the manifest fetching logic in #13. I realized that it's cleaner to just parse manifests directly from the marketplace than to parse our configs for
Also because this proved to be a problem recently that configs contained outdated worker endpoints so fetching the manifest that way failed for more than a few. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #11
Resolves #4
Why I choose to do it like this:
ubiquityos-config.yml, that's all the plugins which are active and installable (in theory as quite a few produce errors when fetching their manifest)I could just read the
manifest.jsondirectly from each repo in-marketplaceinstead if that's the 'official' marketplace for installable plugins.You've always been the CSS guy between us @0x4007, I lack the finesse, maybe a task specifically for handling the huge configs and designing config customizations
QA:
If you look at the worker URL keys in
localStoragethey look kinda messy. We should update them to all have uniform names if possible.