Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit: Sign in with GitHub #3

Closed
0x4007 opened this issue Feb 21, 2024 · 14 comments
Closed

Audit: Sign in with GitHub #3

0x4007 opened this issue Feb 21, 2024 · 14 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Feb 21, 2024

Incorporate a sign in with GitHub button for increased auth limits. Don't worry about styling, I can handle it.

https://github.com/ubiquity/work.ubq.fi/blob/development/src/home/authentication.ts

We should take the sign in with GitHub implementation I made on work.ubq.fi and authenticate as the user for increased rate limits.

How is authentication being handled now?

Originally posted by @pavlovcik in ubiquity/pay.ubq.fi#164 (comment)

@guha-rahul
Copy link

The sign in with Github is already implemented. Can u please explain a little more?

@0x4007
Copy link
Member Author

0x4007 commented Feb 24, 2024

The sign in with Github is already implemented. Can u please explain a little more?

There's no sign in with GitHub implemented on this project.

@molecula451
Copy link
Member

if it's going to be refactor i think it's best to focus energy on ubiquity/pay.ubq.fi#174 and move all these tasks there

@0x4007
Copy link
Member Author

0x4007 commented Feb 28, 2024

This is only needed in the audit app. So actually this issue will be transferred to that repository once its broken off from this one.

@gentlementlegen
Copy link
Member

@pavlovcik this should be taken care of after eventually resolving ubiquity/pay.ubq.fi#172
and actually, once this is merged, calls to GitHub API are extremely low since it would only query the repo information, and not all the comments / issues etc, making this issue low prio.

@0x4007
Copy link
Member Author

0x4007 commented Feb 29, 2024

Priority 1 normal is our lowest priority!

@molecula451 molecula451 transferred this issue from ubiquity/pay.ubq.fi Mar 3, 2024
@gentlementlegen
Copy link
Member

Partially solved by #5 for the auth limits, since it would just poke the database and eventually GitHub a very little for repository informations.

@0x4007
Copy link
Member Author

0x4007 commented Mar 5, 2024

Partially solved by #5 for the auth limits, since it would just poke the database and eventually GitHub a very little for repository informations.

Cool to hear. Meaning it solves the rate limit issue but doesn't include the sign in with GitHub button? This should be fine to get some credit for since #5 is technically a different scope

I also realize that the pricing didn't make it over. @molecula451 would you happen to have a record of the priority and time levels for the issues? Can you re add them so that compensation can be distributed?

@gentlementlegen
Copy link
Member

Partially solved by #5 for the auth limits, since it would just poke the database and eventually GitHub a very little for repository informations.

Cool to hear. Meaning it solves the rate limit issue but doesn't include the sign in with GitHub button? This should be fine to get some credit for since #5 is technically a different scope

I also realize that the pricing didn't make it over. @molecula451 would you happen to have a record of the priority and time levels for the issues? Can you re add them so that compensation can be distributed?

Correct, because we don't require any login to access our database, and we have no rate limit. Now the ratio would be one hit to GitHub API per repo audited, so if you audit 5000 repositories within an hour you might hit the API restrictions. Could still be a nice to have, but not very likely to happen is it?

From the GitHub docs REST API

All of these requests count towards your personal rate limit of 5,000 requests per hour. Requests made on your behalf by a GitHub App that is owned by a GitHub Enterprise Cloud organization have a higher rate limit of 15,000 requests per hour.

@molecula451
Copy link
Member

I also realize that the pricing didn't make it over. @molecula451 would you happen to have a record of the priority and time levels for the issues? Can you re add them so that compensation can be distributed?

Yes, this was the actual price label:

Screenshot from 2024-03-04 23-29-43

@molecula451
Copy link
Member

i can bump if anything, tho

Copy link

ubiquibot bot commented Mar 5, 2024

@FernandVEYRIER the deadline is at 2024-03-05T07:24:10.251Z

@0x4007 0x4007 closed this as completed Mar 5, 2024
Copy link

ubiquibot bot commented Mar 5, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Mar 5, 2024

[ 30.2 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification16.6
IssueComment423.6
Conversation Incentives
CommentFormattingRelevanceReward
Incorporate a sign in with GitHub button for increased auth limi...
6.616.6
> The sign in with Github is already implemented. Can u please e...
2.20.042.2
This is only needed in the audit app. So actually this issue wil...
50.1055
Priority 1 normal is our lowest priority!...
1.40.431.4
> Partially solved by https://github.com/ubiquity/audit.ubq.fi/i...
150.5315

[ 45.6 WXDAI ]

@FernandVEYRIER
Contributions Overview
ViewContributionCountReward
IssueTask125
IssueComment30
IssueComment320.6
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik this should be taken care of after eventually resolvi...
-0.275-
Partially solved by https://github.com/ubiquity/audit.ubq.fi/iss...
-0.555-
> > Partially solved by #5 for the auth limits, since it would j...
-
code:
  count: 1
  score: "0"
  words: 0
0.63-
@pavlovcik this should be taken care of after eventually resolvi...
5.20.2755.2
Partially solved by https://github.com/ubiquity/audit.ubq.fi/iss...
3.20.5553.2
> > Partially solved by #5 for the auth limits, since it would j...
12.2
code:
  count: 1
  score: "1"
  words: 0
0.6312.2

[ 4 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueComment34
Conversation Incentives
CommentFormattingRelevanceReward
if it's going to be refactor i think it's best to focus energy o...
2.70.22.7
> I also realize that the pricing didn't make it over. @molecula...
0.70.7150.7
i can bump if anything, tho ...
0.60.1050.6

[ 1.5 WXDAI ]

@guha-rahul
Contributions Overview
ViewContributionCountReward
IssueComment11.5
Conversation Incentives
CommentFormattingRelevanceReward
The sign in with Github is already implemented. Can u please exp...
1.50.211.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants