-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit: Sign in with GitHub #3
Comments
The sign in with Github is already implemented. Can u please explain a little more? |
There's no sign in with GitHub implemented on this project. |
if it's going to be refactor i think it's best to focus energy on ubiquity/pay.ubq.fi#174 and move all these tasks there |
This is only needed in the audit app. So actually this issue will be transferred to that repository once its broken off from this one. |
@pavlovcik this should be taken care of after eventually resolving ubiquity/pay.ubq.fi#172 |
Priority 1 normal is our lowest priority! |
Partially solved by #5 for the auth limits, since it would just poke the database and eventually GitHub a very little for repository informations. |
Cool to hear. Meaning it solves the rate limit issue but doesn't include the sign in with GitHub button? This should be fine to get some credit for since #5 is technically a different scope I also realize that the pricing didn't make it over. @molecula451 would you happen to have a record of the priority and time levels for the issues? Can you re add them so that compensation can be distributed? |
Correct, because we don't require any login to access our database, and we have no rate limit. Now the ratio would be one hit to GitHub API per repo audited, so if you audit 5000 repositories within an hour you might hit the API restrictions. Could still be a nice to have, but not very likely to happen is it? From the GitHub docs REST API
|
Yes, this was the actual price label: |
i can bump if anything, tho |
@FernandVEYRIER the deadline is at 2024-03-05T07:24:10.251Z |
+ Evaluating results. Please wait... |
Incorporate a sign in with GitHub button for increased auth limits. Don't worry about styling, I can handle it.
https://github.com/ubiquity/work.ubq.fi/blob/development/src/home/authentication.ts
Originally posted by @pavlovcik in ubiquity/pay.ubq.fi#164 (comment)
The text was updated successfully, but these errors were encountered: