Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to check that core contracts storage is not corrupted #862

Closed
ubiquibot bot opened this issue Aug 25, 2023 · 1 comment
Closed

Add workflow to check that core contracts storage is not corrupted #862

ubiquibot bot opened this issue Aug 25, 2023 · 1 comment

Comments

@ubiquibot
Copy link
Contributor

ubiquibot bot commented Aug 25, 2023

ubiquity/ubiquity-dollar#775

@Keyrxng
Copy link
Contributor

Keyrxng commented Aug 27, 2023

Is a new workflow the preferred way to go?

Take a look at UpgradeScripts.sol, it may be of interest.

This would identify any changes through Foundry pre-commit which would also log into the current workflows as part of build-and-test. I've built UUPS into core already and was going to use this right off the bat but decided against it to reduce adding in more parts to the changes but it's easy enough to set up. The logs are pretty verbose too, I've used it recently and think it's great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant