-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint card for Ubiquity Dollars #267
Comments
/start |
Tips:
|
1 similar comment
Tips:
|
Tips:
|
@rndquu I have an MVP that is ready (~80%) and works locally on fixed and custom priced gift cards. |
@EresDev rfc |
There are tools included with this repository to generate a permit for testing. But just for info, permit is generated by ubiquibot in its permit-generation plugin on a specific github event, which is when an issue is closed on a successful merge of a PR that solves that issue. |
How permit generation works:
As
In the context of the "Mint card for Ubiquity Dollars" feature you don't need permits at all unless I'm missing smth. In the |
@whilefoo the deadline is at Sat, Sep 21, 4:18 PM UTC |
@rndquu do ubiquity dollars need to be sent to the treasury wallet? |
@EresDev requested I make a brand new wallet for it- something about a clean transaction history. I would guess that a smart contract would be considered more professional but I think for now there are no functional differences. Unfortunately I can't find the wallet I made for it yet. I suppose we can always make a new one. |
There is a treasury wallet used only to receive payments for minting card. It is not used for any other purpose.
The one you gave me as the treasury wallet for cards was |
Where do I get reloadly sandbox api keys? |
DMed you in telegram |
@whilefoo, this task has been idle for a while. Please provide an update. |
The plan is:
All the steps write in the local storage because the user can refresh the page or something goes wrong in the process. At the bottom of the page the history will be displayed with all cards ordered or claimed |
Need to reduce clutter in UI. Should focus on instantly removing the cards from UI once they are imported to Apple Pay etc |
We can remove the cards from the history if the redeem code was revealed but that doesn't guarantee that they already imported it to Apple Pay |
That AND a seven day timeout should guarantee no problems |
@whilefoo, this task has been idle for a while. Please provide an update. |
@whilefoo the deadline is at Tue, Oct 15, 7:56 AM UTC |
That probably makes sense!
I'm not sure why but I have seen this rarely. |
I suppose that's because #313 targets a none default branch of the https://github.com/ubiquity/pay.ubq.fi repo |
This issue should be closed as completed in #313, correct? |
|
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 1200 |
Issue | Comment | 5 | 0 |
Review | Comment | 13 | 0 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu do ubiquity dollars need to be sent to the treasury wall… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0 result: 0 | 0.8 | 0 |
Where do I get reloadly sandbox api keys? | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0 result: 0 | 0.7 | 0 |
The plan is:- User enters the amount in Ubiquity dollars in th… | 6.5content: content: p: score: 0 elementCount: 13 ul: score: 1 elementCount: 1 li: score: 0.5 elementCount: 11 result: 6.5 regex: wordCount: 191 wordValue: 0 result: 0 | 1 | 0 |
We can remove the cards from the history if the redeem code was … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0 | 0.6 | 0 |
Ah it looks like I was unassigned. Maybe we could add a feature … | 5content: content: p: score: 0 elementCount: 3 img: score: 5 elementCount: 1 result: 5 regex: wordCount: 53 wordValue: 0 result: 0 | 0.4 | 0 |
Resolves #267 ![image](https://github.com/user-attachments/ass… | 15content: content: p: score: 0 elementCount: 4 img: score: 5 elementCount: 3 result: 15 regex: wordCount: 2 wordValue: 0 result: 0 | 0.2 | 0 |
`txParsed.args.signature` is the signature of the permit… | 0content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 34 wordValue: 0 result: 0 | 0.8 | 0 |
I wasn't sure how to name it, since the main page also has card … | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0 result: 0 | 0.3 | 0 |
It's a separate page | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0 result: 0 | 0.3 | 0 |
it's set by the frontend | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0 | 0.5 | 0 |
it's just returning response, not mocking | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 7 wordValue: 0 result: 0 | 0.4 | 0 |
it is traveling over the network. The `functions` folder… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0 | 0.5 | 0 |
that's interesting because when I tried to access it by property… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0 result: 0 | 0.6 | 0 |
We can add all but it doesn't make sense to do it because we onl… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 20 wordValue: 0 result: 0 | 0.4 | 0 |
Yes we can generate permits on any network that has permit2 cont… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0 result: 0 | 0.7 | 0 |
I only found this in their blog: Permit2 is deployed to the [s… | 5content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 33 wordValue: 0 result: 0 | 0.5 | 0 |
Are we fine with merging this? | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0 result: 0 | 0.1 | 0 |
Actually I'm not sure why it's marked as unused dependency becau… | 0content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0 result: 0 | 0.4 | 0 |
[ 2.03275 UUSD ]
@pbkompasz
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 2.03275 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu I have an MVP that is ready (~80%) and works locally on … | 8.66content: content: p: score: 0 elementCount: 2 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 69 wordValue: 0.1 result: 3.66 | 0.85 | 2.03275 |
[ 11.23 UUSD ]
@0x4007
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 5 | 4.495 |
Review | Comment | 14 | 6.735 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@EresDev rfc | 0.18content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 2 wordValue: 0.1 result: 0.18 | 0.65 | 0.117 |
@EresDev requested I make a brand new wallet for it- something a… | 3.2content: content: p: score: 0 elementCount: 1 br: score: 0 elementCount: 1 result: 0 regex: wordCount: 59 wordValue: 0.1 result: 3.2 | 0.75 | 2.4 |
Need to reduce clutter in UI. Should focus on instantly removing… | 1.44content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 23 wordValue: 0.1 result: 1.44 | 0.8 | 1.152 |
That AND a seven day timeout should guarantee no problems | 0.71content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71 | 0.6 | 0.426 |
That probably makes sense!I'm not sure why but I have seen thi… | 1content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 15 wordValue: 0.1 result: 1 | 0.4 | 0.4 |
We bridged it to gnosis chain but it has a different address ht… | 1.11content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0.1 result: 1.11 | 0.7 | 0.777 |
There's I think 12 networks permit2 is deployed on. Might want t… | 1.17content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17 | 0.6 | 0.702 |
What exactly is type derived from? | 0.46content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46 | 0.5 | 0.23 |
It seems like you're mocking network responses here locally? | 0.71content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71 | 0.8 | 0.568 |
Can be a problem if we are bridging to other chains as we did | 0.94content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94 | 0.4 | 0.376 |
Why did you sort under ubiquity dollar directory? | 0.59content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59 | 0.3 | 0.177 |
Shouldn't this be named something like card minting instead of u… | 0.88content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 13 wordValue: 0.1 result: 0.88 | 0.4 | 0.352 |
My point is I'm confused why you're setting an HTTP status code … | 1.75content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0.1 result: 1.75 | 0.5 | 0.875 |
I guess if it's a big project we can handle in another pull but … | 1.75content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0.1 result: 1.75 | 0.6 | 1.05 |
We should at least support optimism (10) as well then. | 0.71content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 10 wordValue: 0.1 result: 0.71 | 0.7 | 0.497 |
Why not throw an error? | 0.39content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39 | 0.6 | 0.234 |
I will need to adjust these numbers later. Given that they aren'… | 1.9content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 32 wordValue: 0.1 result: 1.9 | 0.3 | 0.57 |
Can you fix zod knip | 0.39content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39 | 0.2 | 0.078 |
You can ignore the warning by tweaking the config worst case sce… | 0.83content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 12 wordValue: 0.1 result: 0.83 | 0.3 | 0.249 |
[ 6.0755 UUSD ]
@EresDev
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 2 | 4.3125 |
Review | Comment | 1 | 1.763 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
In this MVP the "standard" permit is built by a script and is pa… | 17.07content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 2 result: 10 regex: wordCount: 150 wordValue: 0.1 result: 7.07 | 0.8 | 3.9165 |
There is a treasury wallet used only to receive payments for min… | 2.64content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 47 wordValue: 0.1 result: 2.64 | 0.6 | 0.396 |
This is correct. It is [Result](https://docs.ethers.org/v5/api… | 7.54content: content: p: score: 0 elementCount: 3 a: score: 5 elementCount: 1 result: 5 regex: wordCount: 45 wordValue: 0.1 result: 2.54 | 0.8 | 1.763 |
[ 124.712 UUSD ]
@rndquu
Contributions Overview
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 83.28 |
Issue | Comment | 4 | 29.452 |
Review | Comment | 1 | 11.98 |
Conversation Incentives
Comment | Formatting | Relevance | Reward |
---|---|---|---|
[This](https://github.com/ubiquity/pay.ubq.fi/pull/226) PR intro… | 27.76content: content: p: score: 0 elementCount: 11 a: score: 5 elementCount: 3 ol: score: 1 elementCount: 2 li: score: 0.5 elementCount: 7 ul: score: 1 elementCount: 1 result: 21.5 regex: wordCount: 130 wordValue: 0.1 result: 6.26 | 1 | 83.28 |
@pbkompasz How permit generation works:1. Github issue is cl… | 28.39content: content: p: score: 0 elementCount: 6 ol: score: 1 elementCount: 1 li: score: 0.5 elementCount: 2 a: score: 5 elementCount: 4 result: 22 regex: wordCount: 133 wordValue: 0.1 result: 6.39 | 0.85 | 27.4315 |
DMed you in telegram | 0.32content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 4 wordValue: 0.1 result: 0.32 | 0.2 | 0.064 |
I suppose that's because https://github.com/ubiquity/pay.ubq.fi/… | 1.75content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 29 wordValue: 0.1 result: 1.75 | 0.65 | 1.1375 |
This issue should be closed as completed in https://github.com/u… | 1.17content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0.1 result: 1.17 | 0.7 | 0.819 |
Here `txParsed.args.signature` refers to [method signatu… | 12.2content: content: p: score: 0 elementCount: 1 a: score: 5 elementCount: 2 result: 10 regex: wordCount: 38 wordValue: 0.1 result: 2.2 | 0.9 | 11.98 |
This PR introduced a feature of card minting.
How it works:
pay.ubq.fi
to redeem our "standard" permit rewardpay.ubq.fi
backendAny user with Ubiquity Dollars should be able to mint a gift card (not only the ones with ready to use permits).
What should be done:
pay.ubq.fi/cards
) where users will be able to send Ubiquity Dollars to the treasury address and get reloadly gift cards in returnNotice:
The text was updated successfully, but these errors were encountered: