Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Robust Bot Permit Comment Recognition #551

Closed
0x4007 opened this issue Jul 27, 2023 · 2 comments
Closed

Robust Bot Permit Comment Recognition #551

0x4007 opened this issue Jul 27, 2023 · 2 comments
Labels
Priority: 1 (Normal) Time: <1 Hour

Comments

@0x4007
Copy link
Member

0x4007 commented Jul 27, 2023

We should parse the permit generation comments using URLSearchParams because we may add more URL search parameters to the URL in the future. Also the current approach is strict on the ordering of the parameters which seems brittle.

Yes, parsing the URL with URLSearchParams is a better approach

This PR solves the original issue + we don't have plans of adding more query params besides claim and network so I don't think that refactoring to URLSearchParams is an urgent issue

Besides, isn't it supposed to be https://pay.ubq.fi/?claim=

No, the generated URL is https://pay.ubq.fi?claim= so everything is fine

Originally posted by @rndquu in #508 (comment)
@ubiquibot ubiquibot bot mentioned this issue Jul 27, 2023
Closed
@rndquu
Copy link
Member

rndquu commented Jul 27, 2023

Duplicate #526

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
@ubiquibot
Copy link

ubiquibot bot commented Jul 27, 2023

Permit generation skipped because the issue was not closed as completed

If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

@0x4007 0x4007 mentioned this issue Aug 17, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Priority: 1 (Normal) Time: <1 Hour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0x4007 @rndquu