Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Proposal: semi automated QA #626

Open
1 of 3 tasks
0x4007 opened this issue Aug 16, 2023 · 3 comments
Open
1 of 3 tasks

Proposal: semi automated QA #626

0x4007 opened this issue Aug 16, 2023 · 3 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Aug 16, 2023

We can consider making a CI script to test all of the functions on every commit similar to how @web4er does manual QA.

Perhaps this GitHub action can open a new issue and do a routine. Perhaps it can also tag the title with the commit hash so that it is easier to identify which commit the tests correspond to.

context: #621 (review)

Task list

@web4er
Copy link
Contributor

web4er commented Aug 17, 2023

A minimum goal to start would be some end-to-end tests that run all commands and check their responses.

A lengthy goal would be to also include unit tests with mocked github events and other mocked infrastructure dependencies like logger, database, etc leading to the possibility of high coverage and test-driven development style.

It wouldn't be just CI step, yarn test will also help developers to get quick feedback if they broke something with new changes.

@rndquu
Copy link
Member

rndquu commented Oct 11, 2023

@web4er Could you elaborate on the difference between these 2 issues: #634 and #635?

From my point of view they're basically the same because implementing #634 implies mocking 3rd party dependencies (logger, supabase DB, etc...) so I don't really understand why we need this issue. Perhaps we should close this one?

@0x4007
Copy link
Member Author

0x4007 commented Oct 19, 2023

It was just to break apart the project into two phases.

The first being the essentials, the second being basically everything else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants