From 3e962865d4e022e73495165e8b3d32f6012ecbb3 Mon Sep 17 00:00:00 2001 From: Korrrba Date: Fri, 19 Jan 2024 18:30:42 +0100 Subject: [PATCH] test: fix ShouldSetAdminRoleForGivenRole and add test for revert --- .../diamond/facets/AccessControlFacet.t.sol | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol b/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol index a64a93d6d..b7c801b18 100644 --- a/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol +++ b/packages/contracts/test/diamond/facets/AccessControlFacet.t.sol @@ -136,18 +136,24 @@ contract AccessControlFacetTest is DiamondTestSetup { assertEq(adminRole, DEFAULT_ADMIN_ROLE); } - // test setRoleAdmin function should set correct admin role + function testSetRoleAdmin_ShouldRevertWhenNotAdmin() public { + vm.prank(mock_sender); + + vm.expectRevert("Manager: Caller is not admin"); + accessControlFacet.setRoleAdmin( + DOLLAR_TOKEN_BURNER_ROLE, + DEFAULT_ADMIN_ROLE + ); + } + function testSetRoleAdmin_ShouldSetAdminRoleForGivenRole() public { bytes32 adminRole = accessControlFacet.getRoleAdmin( DOLLAR_TOKEN_MINTER_ROLE ); - assertEq(adminRole, DOLLAR_TOKEN_MINTER_ROLE); + assertEq(adminRole, DEFAULT_ADMIN_ROLE); vm.prank(admin); - accessControlFacet.setRoleAdmin( - DOLLAR_TOKEN_MINTER_ROLE, - DOLLAR_TOKEN_BURNER_ROLE - ); + accessControlFacet.setRoleAdmin(DOLLAR_TOKEN_MINTER_ROLE, PAUSER_ROLE); adminRole = accessControlFacet.getRoleAdmin(DOLLAR_TOKEN_MINTER_ROLE); - assertEq(adminRole, DOLLAR_TOKEN_BURNER_ROLE); + assertEq(adminRole, PAUSER_ROLE); } }