Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOW] - Collateral ratio should be capped #929

Closed
0xadrii opened this issue Apr 19, 2024 · 2 comments · Fixed by #932
Closed

[LOW] - Collateral ratio should be capped #929

0xadrii opened this issue Apr 19, 2024 · 2 comments · Fixed by #932
Assignees
@gitcoindev

Comments

@0xadrii
Copy link

0xadrii commented Apr 19, 2024 

          [LOW] - Collateral ratio should be capped

As seen in Frax's code, collateral ratio will always be capped at 100%. For Ubiquity, if a higher value is wrongly set and the dynamic CR is implemented, then it could cause some issues. It is recommended to add a maximum value for newCollateralRatio of 1_000_000.

Originally posted by @0xadrii in #922 (comment)
@gitcoindev gitcoindev self-assigned this Apr 20, 2024
@gitcoindev
Copy link
Contributor

gitcoindev commented Apr 20, 2024 •
edited
Loading

Seems straightforward to implement, I will pick it up.

gitcoindev added a commit to gitcoindev/ubiquity-dollar that referenced this issue Apr 20, 2024
@gitcoindev
feat: cap collateral ratio to 100%
f6af72a 
Resolves: ubiquity#929
@gitcoindev gitcoindev mentioned this issue Apr 20, 2024
Merged
molecula451 pushed a commit that referenced this issue Apr 20, 2024
@gitcoindev
feat: cap collateral ratio to 100% (#932)
562529d 
Resolves: #929
@ubiquibot UbiquiBot
Copy link

ubiquibot bot commented Apr 20, 2024 

! action has an uncaught error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitcoindev gitcoindev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cap collateral ratio to 100% gitcoindev/ubiquity-dollar
2 participants
@0xadrii @gitcoindev