Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add testnet rpc tunnel workflow #799

Closed

Conversation

gitcoindev
Copy link
Contributor

Resolves: #493

QA: gitcoindev#1 (comment) (and comments below).

@rndquu
Copy link
Member

rndquu commented Oct 2, 2023

We already have pretty much the same workflow for anvil so I don't think that we should merge the current PR.

Meanwhile we got a pretty much detailed instructions on how to setup custom domain for cloudflare tunnels so everything else is on us. I would:

  1. Close the current PR without merging
  2. Mark the issue as solved

@gitcoindev
Copy link
Contributor Author

I am fine with @rndquu 's suggestion, the PR was to provide an example setup with QA.

@molecula451
Copy link
Member

the workflow probably will still need to be modified after set up everything at #493 (comment) (which are clean instructions) so we either

  1. Close and render new stuff after setup at Testnet RPCs under ubq.fi domain #493 (comment)
  2. Leave the PR open until everything setups and modify the stuff need it in this same PR

@rndquu
Copy link
Member

rndquu commented Oct 4, 2023

the workflow probably will still need to be modified after set up everything at #493 (comment)

Yes, I will modify it

Leave the PR open until everything setups and modify the stuff need it in this same PR

Bounty hunters don't need to wait for us until we do our stuff. They'd better start solving some other issue in the meantime. That is why I think that we can mark the issue as solved.

@molecula451
Copy link
Member

the workflow probably will still need to be modified after set up everything at #493 (comment)

Yes, I will modify it

Leave the PR open until everything setups and modify the stuff need it in this same PR

Bounty hunters don't need to wait for us until we do our stuff. They'd better start solving some other issue in the meantime. That is why I think that we can mark the issue as solved.

+1

@molecula451 molecula451 closed this Oct 4, 2023
@gitcoindev
Copy link
Contributor Author

Thank you for approving!

@molecula451
Copy link
Member

keep us sending this quality sharing, code, info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testnet RPCs under ubq.fi domain
3 participants