Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch rollback-helper to bootc switch #1913

Open
castrojo opened this issue Nov 9, 2024 · 6 comments · May be fixed by #1915
Open

Switch rollback-helper to bootc switch #1913

castrojo opened this issue Nov 9, 2024 · 6 comments · May be fixed by #1915
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Keep Bluefin alive, dive in!

Comments

@castrojo
Copy link
Member

castrojo commented Nov 9, 2024

https://github.com/ublue-os/bluefin/blob/main/system_files/shared/usr/bin/ublue-rollback-helper

This should be using sudo bootc switch ghcr.io/ublue-os/blah --enforce-container-sigpolicy instead.

@castrojo castrojo added good first issue Good for newcomers help wanted Keep Bluefin alive, dive in! labels Nov 9, 2024
@dosubot dosubot bot added the enhancement New feature or request label Nov 9, 2024
@DarkGhostHunter
Copy link

Does bootc works only when the image has no layered software? Because I wouldn't be able to rebase if the latter is true and I have layered something.

@p5
Copy link
Member

p5 commented Nov 9, 2024

Does bootc works only when the image has no layered software? Because I wouldn't be able to rebase if the latter is true and I have layered something.

If we did this, I'd imagine there would be logic to say "if the image has no layered packages, use Bootc. Otherwise rpm-ostree"

@lem4s
Copy link

lem4s commented Nov 9, 2024

I tried to implement the change and got an odd result testing it. If the command is run inside the ublue-rollback-helper script, I get the following error message: ERROR Switching: Pulling: Creating importer: failed to invoke method OpenImage: failed to invoke method OpenImage: Requesting bearer token: invalid status code from registry 403 (Forbidden).

However if I just do the same on the console, i.e. run sudo bootc switch ghcr.io/ublue-os/bluefin:41-20241109 myself it starts fetching the image...

Any ideas why this is the case?

@m2Giles
Copy link
Member

m2Giles commented Nov 9, 2024 via email

@lem4s
Copy link

lem4s commented Nov 9, 2024

Yes you are correct. I found the issue.

@castrojo
Copy link
Member Author

If we did this, I'd imagine there would be logic to say "if the image has no layered packages, use Bootc. Otherwise rpm-ostree"

bootc also tells the user what to do if you try to switch with layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Keep Bluefin alive, dive in!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants