Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

allow git to be not managed by fleek #200

Closed
1024bees opened this issue May 14, 2023 · 5 comments · Fixed by #214
Closed

allow git to be not managed by fleek #200

1024bees opened this issue May 14, 2023 · 5 comments · Fixed by #214

Comments

@1024bees
Copy link
Contributor

1024bees commented May 14, 2023

Is your feature request related to a problem? Please describe.
Currently git 2.40 has some buggy behaviour that emerges with rust, see arxanas/git-branchless#894 and libgit2/libgit2#6531

Describe the solution you'd like
Allowing git to be not managed by fleek -- this is a bit of a toe stubber and being able to have a system git used would be nice

Describe alternatives you've considered
Having git version be able to be tightly controlled by fleek e.g, being able to rollback to git 2.39.2 would work, however this doesn't seem to be a natural use case of nix

@bketelsen
Copy link
Member

This one is tricky, because fleek's configuration has a lot of dependencies on git. If we remove git from the install, we will have to remove all the git configuration from the generated flake as well.

@1024bees
Copy link
Contributor Author

1024bees commented Jun 11, 2023

Yeah, that makes sense. I'd be open to attempt create an MR for whatever interface you'd prefer for managing package version / git version / etc. All id like is a way to manage git version specifically.

Also understandable if you'd just like to punt on it -- it does make rust development frustrating but I have work around on my end (temporarily renaming the .git folder).

@bketelsen
Copy link
Member

If you were using home-manager directly how would you accomplish this?

@bketelsen
Copy link
Member

fixed by #214
PR 214 adds a yaml boolean "byo_git", which will prevent fleek from installing git and remove any git configurations from the generated home config.

@1024bees
Copy link
Contributor Author

If you were using home-manager directly how would you accomplish this?

To be honest, no idea how I'd do this, but #214 looks perfect. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants