Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR reviews #61

Open
dnxjay opened this issue Oct 16, 2024 · 2 comments
Open

PR reviews #61

dnxjay opened this issue Oct 16, 2024 · 2 comments
Labels
question Further information is requested
Milestone
Homework 3 Due 20...

Comments

@dnxjay
Copy link

dnxjay commented Oct 16, 2024

What's the expectations to earn full points for the PR reviews
@dnxjay dnxjay added the question Further information is requested label Oct 16, 2024
@dnxjay dnxjay added this to the Homework 3 Due 2024-10-16 2pm milestone Oct 16, 2024
@dnxjay
Copy link
Author

dnxjay commented Oct 16, 2024

actually just noticed this in #13 for anyone with the same question

@dnxjay dnxjay closed this as completed Oct 17, 2024
@haiderabbas007
Copy link
Contributor

What if we want to request changes? In that case, do we have to wait until the final approval?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
Homework 3 Due 2024-10-16 2pm
Development

No branches or pull requests
2 participants
@haiderabbas007 @dnxjay