-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "Album Artist" #339
Add support for "Album Artist" #339
Comments
good idea! will do :) |
I guess you want to have it both for filtering the library and filtering your search, right? |
I think both, but really I want everything between Gorillaz and Blink to be categorized under "Gorillaz". Elvis Presley and Elvis vs JXL should both be categorized under "Elvis Presley", etc. |
just realized, even though I added the filter |
@mortgagemetrix if this field in the metadata is empty should we fallback to "artist" or rather make it empty? |
@Feichtmeier Default to artist. iTunes/Music.app does default to Artist field if the Album Artist is not available. Both iTunes and MusicBrainz (Picard) also include optional sort values that default to their respective primary values. A good example is "Stressed Out" by "A Tribe Called Quest feat. Faith Evans". I've included a screen shot of a song that was tagged before "album artist" or sort options existed and show how it compares to when the same song is tagged via Picard. With iTunes, the directory name is Album Artist. Album Artist Sort Order is only used for the interface. That way A Tribe Called Quest sorts under T, and The Beatles sort under B. Here is a link to the same album on the musicbrainz site: https://musicbrainz.org/release/73ebe2f8-40dd-45fb-8f28-0f1c0885aae4?tport=8000 |
Thanks 🙏 Ok that's what I did! Have a look at the snap edge in about 30 minutes or when the next stable release happens |
I checked it out and have some feedback. I accidentally installed both the flatpak version and the snap edge version. Both are generally behaving the same way. Here is some feedback.
|
could you show for 1. some sort of screenshot? for my music library this is not the case also there are filters for everything? do you mean when filtered for album? for 2. this is also not the case for me, are your files tagged correctly? |
Here's Eminem from the 8 Mile Soundtrack. Album Artist is various artists, Artist is Eminiem. Here are some raw ID3 tags from mutagen:
|
hm, then something in audio_metada_reader must be still not correct I suppose I think it assumes that the tagging always puts albumartist and artist in the same field and then needs splitting by ',' but this is not correct for all mp3s because some tag artist as "Cradle Of Filth" albumArtist as "Various Artists" and others write a list of "Cradle Of Filth, Mayhem, Dimmu Borgir" and artist "Cradle Of Filth" from the first element in this list @ClementBeal shall I re-open the issue in your repo ? I tried to make a PR but I am too anxious to mess the other file formats up so I better don't https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html says Involved persons frames TPE1 TPE2 TPE3 TPE4 TOPE TEXT TOLY TCOM TMCL TIPL TENC but then the cases where artist is different from the first field (or the only field) of a list wrapped in albumArtist is wrong I think itstead of using this performers field, you need an albumArtist field that does what artist currently uses mp3Metadata.bandOrOrchestra and then artist only should be mp3Metadata.leadPerformer ?? |
Albums with a lot of guest artists like "Plastic Beach" by Gorillaz have many different artists listed. 11 separate artist lines for that app alone. The Album Artist field is just "Gorillaz". It may be academic as I see no way to view or edit song metadata anyway.
The text was updated successfully, but these errors were encountered: