Skip to content

Commit 22b83b5

Browse files
fix query and add test (#17)
1 parent cffbe56 commit 22b83b5

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

gen3/submission.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ def query(self, query_txt, variables=None, max_tries=1):
313313

314314
tries = 0
315315
while tries < max_tries:
316-
output = requests.post(api_url, auth=self._auth_provider, json=query)
316+
output = requests.post(api_url, auth=self._auth_provider, json=query).text
317317
data = json.loads(output)
318318

319319
if "errors" in data:

tests/submission_test.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,17 @@ def test_delete_record(sub):
129129
sub.delete_record("prog1", "proj1", "id")
130130

131131

132+
def test_query(sub):
133+
with patch("gen3.submission.requests") as mock_request:
134+
mock_request.status_code = 200
135+
mock_request.post().text = '{ "key": "value" }'
136+
res = sub.query("{ experiment { submitter_id } }")
137+
assert res == {"key": "value"}
138+
139+
132140
""" Not tested:
133141
134-
- query : visual tests
142+
- query : more tests
135143
- get_project_manifest: lack of swagger documentation.
136144
error about not submitting ids
137145
- submit_file

0 commit comments

Comments
 (0)