Fix Gen3Index create_record to return the full record

Author: k-burt-uch

gen3/index.py

@@ -427,7 +427,6 @@ def create_record(
             urls = []
         json = {
             "urls": urls,
-            "form": "object",
             "hashes": hashes,
             "size": size,
             "file_name": file_name,
@@ -443,15 +442,9 @@ def create_record(
         }
         if did:
             json["did"] = did
-        resp = self.client._post(
-            "index/",
-            headers={"content-type": "application/json"},
-            data=client.json_dumps(json),
-            auth=self.client.auth,
-        )
-        raise_for_status_and_print_error(resp)
+        rec = self.client.create(**json)
 
-        return resp.json()
+        return rec.to_json()
 
     @backoff.on_exception(backoff.expo, Exception, **DEFAULT_BACKOFF_SETTINGS)
     async def async_create_record(

tests/test_index.py

@@ -278,3 +278,20 @@ def test_desc_and_content_dates(gen3_index):
     assert version_record["description"] == new_version["description"]
     assert version_record["content_created_date"] == new_version["content_created_date"]
     assert version_record["content_updated_date"] == new_version["content_updated_date"]
+
+def test_create_record_response(gen3_index):
+    """
+    Verifies the return value for create_record echoes back the parameters for the record that was created.
+    """
+    to_create = {
+        "hashes": {
+            "md5": "374c12456782738abcfe387492837483"
+        },
+        "size": 10,
+        "urls": ['s3://foo/bar'],
+        "file_name": 'new_file',
+        "acl": ['*']
+    }
+    record = gen3_index.create_record(**to_create)
+    for field, expected_value in to_create.items():
+        assert expected_value == record[field]