-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot export keys with p256 plugin #108
Comments
Addresses issue ucan-wg#108
On further inspection it could be that I'm misunderstanding the use of the methods on this class. With the provided fix, I can successfully export the key, however it exports it in |
Addresses issue #108 --- * Add an `exportable` option to EcdsaKeyPair Addresses issue #108 * Implement and test import / export for ECDSA Keypair * Import and Export for RSA keys * Import / Export for EdKeypair * [WIP] Remove unit8array as a dependency * [bug] remove unused dependency * [fix] Normalize back to uintarrays [Fix] Normalize on uint8arrays * [feat] Normalize `export` to use JWK types * [fix] added notes about ed25519 export * [fix] Revised comment about export to include other parameters * [fix] Generify ExportableKey type to allow for PrivateKeyJwk return types
Context
I'm trying to use the
EcdsaKeyPair
as a utility to generate a stable keypair. For testing purposes I'm:exportable = true
This works fine using the
EdKeypair
, but fails with "key is not extractable" when using the p256 plugin.I believe the problem is that, when creating a new key, the static method does not allow you to specify
exportable
and hardcodes the extraction parameter to "false" when creating the key.I have a PR that addresses this issue that I will reference here.
The text was updated successfully, but these errors were encountered: