Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize useEffect dependencies #394

Open
laholstege opened this issue Jul 24, 2024 · 0 comments
Open

optimize useEffect dependencies #394

laholstege opened this issue Jul 24, 2024 · 0 comments
Assignees
@laholstege
Milestone
Ordering System

Comments

@laholstege
Copy link
Contributor 

          i think it'd be nicer to extract the `setValue` and `getValues` methods from `method` instead of using `methods.setValue` and then needing to useeffect depend on the entire method object.  Also, why call it methods, maybe at least formMethods but that doesn't really work either because formState is not a method.

Originally posted by @srkirkland in #321 (comment)
@laholstege laholstege added this to the Ordering System milestone Jul 24, 2024
@laholstege laholstege self-assigned this Jul 24, 2024
@laholstege laholstege mentioned this issue Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laholstege laholstege

Labels
None yet
Projects
None yet
Milestone
Ordering System
Development

No branches or pull requests
1 participant
@laholstege