Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "loading" & "no-internet" indicators to the menus #101

Open
HirdayGupta opened this issue Nov 13, 2018 · 1 comment
Open

Add "loading" & "no-internet" indicators to the menus #101

HirdayGupta opened this issue Nov 13, 2018 · 1 comment
Assignees
Labels

Comments

@HirdayGupta
Copy link
Member

Motivation
Right now, while the menus are loading, the user only sees a blank menus. And if the user doesn't have an internet connection, the API just fails silently and menus are blank again. (Simulate these situations and check it out).

The Task

  1. Figure out where in the lifecycle for the MenuVC these changes would be necessary. (this is a huge step and involves a lot)
  2. Figure out how to check when there's no internet connection.
  3. For now, add placeholder labels (saying "no internet" and "loading..") in the storyboard and initialize them as hidden, and then unhide them under the requisite conditions.
  4. These labels will be replaced by graphics that will be coming soon from our designer. Issue will be updated to reflect these, but the pending graphics shouldn't hinder the groundwork necessary for this issue.

Acceptable Criteria

  • When menus are loading (that is, while menu API is still waiting to for the response) - the "loading" graphic/label should appear.
  • If there is no internet connection, an "No internet" label / graphic should appear.
@HirdayGupta
Copy link
Member Author

iphone 8 131

iphone 8 130

iphone 8 129

iphone 8 128

iphone 8 127

iphone 8 126

Those are the images we'd like to use for the loading animation - the image being displayed will change with a timer. We can discuss implementation details about this later, but start with just the label described above!

Thats the scale - the size we want to display the image at:
iphone 8 132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants